linux.kernel
[Top] [All Lists]

Re: [patch] avoid unaligned access when accessing poll stack

Subject: Re: [patch] avoid unaligned access when accessing poll stack
From: OGAWA Hirofumi
Date: Fri, 31 Mar 2006 19:50:18 +0200
Newsgroups: linux.kernel
Andi Kleen <ak@xxxxxxx> writes:

>>      char stack_pps[POLL_STACK_ALLOC]
>>              __attribute__((aligned (sizeof(struct poll_list))));
>
> This would require much more alignment than really necessary. Probably you 
> meant
> s/sizeof/alignof/. But Jes' patch is fine I think.

I read your this patch now, so, I agree. Sorry for noise.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at                                  www.tux.org/lkml/">http://www.tux.org/lkml/

<Prev in Thread] Current Thread [Next in Thread>
Privacy Policy